Backport to branch(3.15) : Fix to avoid deleting non ScalarDB tables when dropping namespaces #3098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to prevent dropping namespaces that contain non-ScalarDB managed tables (tables without metadata). When attempting to drop such namespaces, an IllegalArgumentException is thrown with an informative error message.
- Added
getTableNamesInNamespaceSql()method to RDB engine strategies to query raw table names - Modified
dropNamespace()inJdbcAdminandCosmosAdminto check for non-ScalarDB tables before dropping - Added test utilities (
deleteMetadata()anddropTable()methods) to support testing this scenario
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AdminTestUtils.java | Added abstract methods deleteMetadata() and dropTable() to test utility base class |
| DistributedStorageAdminIntegrationTestBase.java | Added integration test for dropping namespaces with non-ScalarDB managed tables |
| JdbcAdmin.java | Added validation to check for non-ScalarDB tables before dropping namespace |
| CosmosAdmin.java | Added validation to check for non-ScalarDB tables before dropping namespace |
| RdbEngine*.java | Implemented getTableNamesInNamespaceSql() for each database engine |
| CoreError.java | Added error message constant for namespace with non-ScalarDB tables |
| *AdminTestUtils.java | Implemented deleteMetadata() and dropTable() methods for all storage adapters |
| *AdminIntegrationTest.java | Wired up getAdminTestUtils() and disabled test for SQLite/DynamoDB |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated request for a manual backport of the following:
Thank you!